New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-9020][E2E Tests] Use separate modules per testcase #5717
[FLINK-9020][E2E Tests] Use separate modules per testcase #5717
Conversation
@kl0u Could you have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One commit otherwise this looks LGTM.
We should move the plugin version into the plugin management section of the root pom, but that's out of the scope of this PR.
|
||
<modelVersion>4.0.0</modelVersion> | ||
|
||
<artifactId>parent-child-classloading-test</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add
flink
prefix - add
_${scala.binary.version}
suffix - add
<name>flink-parent-child-classloading-test</name>
(this is what allows us to omit the scala stuff when listing child modules)
Thanks @zentol! I addressed your comments and will squash if approved |
merging. |
Use separate maven modules per test case in end-to-end tests
This change sets up the end-to-end project dir in a way that each test that provides its own sources does so with a separate module.
The main motivation is that now each test case can easier specify the way that it is supposed to be built, which could often for example be based on the quickstart example. There then is no need anymore to put together custom packaging instructions for each addition that is added to the test cases.
Brief change log
flink-end-to-end-tests_${scala.binary.version}
toflink-end-to-end-tests
(needed for having a successful build)Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation