Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9020][E2E Tests] Use separate modules per testcase #5717

Conversation

florianschmidt1994
Copy link
Contributor

Use separate maven modules per test case in end-to-end tests

This change sets up the end-to-end project dir in a way that each test that provides its own sources does so with a separate module.
The main motivation is that now each test case can easier specify the way that it is supposed to be built, which could often for example be based on the quickstart example. There then is no need anymore to put together custom packaging instructions for each addition that is added to the test cases.

Brief change log

  • Change parent artifact from jar to pom packaging
  • Rename parent artifact from flink-end-to-end-tests_${scala.binary.version} to flink-end-to-end-tests (needed for having a successful build)
  • Move existing ClassLoader PoC to its own module
  • Fix paths in test scripts

Verifying this change

  • I reran the tests by hand and they still behave the same

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@florianschmidt1994
Copy link
Contributor Author

@kl0u Could you have a look at this?

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One commit otherwise this looks LGTM.

We should move the plugin version into the plugin management section of the root pom, but that's out of the scope of this PR.


<modelVersion>4.0.0</modelVersion>

<artifactId>parent-child-classloading-test</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add flink prefix
  • add _${scala.binary.version} suffix
  • add <name>flink-parent-child-classloading-test</name> (this is what allows us to omit the scala stuff when listing child modules)

@florianschmidt1994
Copy link
Contributor Author

Thanks @zentol! I addressed your comments and will squash if approved

@zentol
Copy link
Contributor

zentol commented Mar 21, 2018

merging.

zentol pushed a commit to zentol/flink that referenced this pull request Mar 21, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Mar 21, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Mar 21, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Mar 21, 2018
@asfgit asfgit closed this in 129e215 Mar 21, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants