[FLINK-8959][tests] Port AccumulatorLiveITCase to flip6 #5719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljoscha
reviewed
Mar 19, 2018
| msg = (TestingJobManagerMessages.UpdatedAccumulators) receiveOne(TIMEOUT); | ||
| try { | ||
| NotifyingMapper.notifyLatch.await(); | ||
| Thread.sleep(HEARTBEAT_INTERVAL * 4); // wait for heartbeat |
There was a problem hiding this comment.
Isn't this test-flakiness waiting to happen? We could run this in a loop and wait until the accumulators are available with a Deadline. If getAccumulators() returned a Future we could even use the utilities in FutureUtils, but can't fix that now, unfortunately... 😓
There was a problem hiding this comment.
Well....yeah we could use a deadline and polling, probably will be even faster.
There was a problem hiding this comment.
@aljoscha Done; also found a way to make use of FutureUtils.
|
Looks good now, when travis is green! 👌 |
|
Good work @zentol. I guess only a rebase is missing. +1 for merging then. |
|
merging. |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5701.
What is the purpose of the change
This PR ports the
AccumulatorLiveITCaseto flip6. The existing test was renamed toLegacyAccumulatorLiveITCase, and a ported copy was added.The heartbeat interval is not configurable for legacy clusters and is hard-coded to 5 seconds. Porting this test (in a reliable fashion) without relying on internal/test APIs would've increased the test duration, so I decided to just leave it as it is.