[FLINK-8957][tests] Port JMXJobManagerMetricTest to flip6 #5720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Mar 22, 2018
There was a problem hiding this comment.
Changes look good to me. Thanks for your work @zentol. +1 for merging.
| () -> client.getJobStatus(jobGraph.getJobID()), | ||
| Time.milliseconds(10), | ||
| deadline, | ||
| status -> status == JobStatus.RUNNING, |
There was a problem hiding this comment.
The check whether the job is running does not necessarily mean that all vertices are running. But I guess what we are waiting for is the initialization of the CheckpointStatsTracker.
|
merging. |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Ports the
JMXJobManagerMetricTestto useMiniClusterResource.Verifying this change
Run
JMXJobManagerMetricTestwithflip6profile enabled/disabled.