[FLINK-8965][tests] Port TimestampITCase to flip6 #5728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Mar 23, 2018
There was a problem hiding this comment.
Changes look good. Thanks for your work @zentol. +1 for merging.
| } | ||
|
|
||
| JobID id = running.get(0); | ||
| JobID id = running.iterator().next(); |
There was a problem hiding this comment.
could also be running.get(0), then we don't create an additional iterator object
There was a problem hiding this comment.
will fix while merging.
|
Test failure on Travis is unrelated: https://issues.apache.org/jira/browse/FLINK-8899 |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 23, 2018
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Ports the
TimestampITCaseto useMiniClusterResource.Verifying this change
Run
TimestampITCasewithflip6profile enabled/disabled.