[FLINK-9045][REST] Add logging message for web UI address #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Apr 13, 2018
There was a problem hiding this comment.
Changes look good to me. +1 for merging.
Additionally, we could try to start the WebMonitorEndpoint with port 8081 if the user calls createLocalEnvironmentWithWebUI on the StreamExecutionEnvironment. The legacy FlinkMiniCluster also started the WebRuntimeMonitor with port 8081.
|
I have removed a section from the This should cause the UI to run at |
|
Correction: I had to modify the |
|
Looks good to merge! 👍 |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Apr 16, 2018
…endly logging message for web UI address - add back known logging mesages about webUI address - do not set random port in local stream environment This closes apache#5814.
zentol
added a commit
to zentol/flink
that referenced
this pull request
Apr 16, 2018
…endly logging message for web UI address - add back known logging mesages about webUI address - do not set random port in local stream environment This closes apache#5814.
zentol
added a commit
to zentol/flink
that referenced
this pull request
Apr 16, 2018
…endly logging message for web UI address -add back known logging mesages about webUI address -do not set random port in local stream environment This closes apache#5814.
zentol
added a commit
to zentol/flink
that referenced
this pull request
Apr 16, 2018
…endly logging message for web UI address -add back known logging mesages about webUI address -do not set random port in local stream environment This closes apache#5814.
…endly logging message for web UI address -add back known logging mesages about webUI address -do not set random port in local stream environment This closes apache#5814.
asfgit
pushed a commit
that referenced
this pull request
Apr 16, 2018
…endly logging message for web UI address -add back known logging mesages about webUI address -do not set random port in local stream environment This closes #5814.
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…endly logging message for web UI address -add back known logging mesages about webUI address -do not set random port in local stream environment This closes apache#5814.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adds a logging message explicitly saying on which address and port the web UI is listening on.
This message is logged in the legacy code-base, but with flip6 we were only logging the REST server address. While technically the same it may not be obvious to users that there is a difference.
Verifying this change
Not tested.