[FLINK-9136][tests] Remove StreamingProgramTestBase #5817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
force-pushed
the
9136
branch
5 times, most recently
from
12f8b80
to
ceeaa65
Compare
|
Looks very good to merge! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #5816.
What is the purpose of the change
This PR removes the
StreamingProgramTestBaseclass.The class discourages the re-use of cluster resources as every test must be setup in a new class. Additionally, it appears to mimic jUnits
@Before/@Afterlife-cycle, but actually doesn't as thepostSubmitmethod is not called not called iftestPogramfails with an exception. This can lead to resource leaks, like for example in theContinuousFileProcessingITCase.Existing usages were ported to the
AbstractTestBase.If a tests was using preSubmit to setup data and postSubmit to verify the result, then the methods were merged into a single method.
Otherwise,
preSubmitimplementations were annotated with@Before,postSubmitimplementations with@After, andtestProgramimplementations with@Test.Additionally the visibility of these methods was set to
public.