[FLINK-9113] [connectors] Use raw local file system for bucketing sink to prevent data loss #5861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to prevent data loss
|
It seems that for Hadoop 2.8.3 truncating is supported for the raw local filesystems. I will need to adapt the test for that. |
aljoscha
approved these changes
Apr 18, 2018
| @@ -1245,6 +1246,12 @@ else if (scheme != null && authority == null) { | |||
| } | |||
|
|
|||
| fs.initialize(fsUri, finalConf); | |||
|
|
|||
| // By default we don't perform checksums on Hadoop's local filesystem and use the raw filesystem. | |||
There was a problem hiding this comment.
The "by default" is not necessary anymore. We now always use the raw filesystem. This is a leftover from the previous version that allowed changing this.
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2018
…k to prevent data loss This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush. Negative effect: Existing checksums are not maintained anymore and thus become invalid. This closes #5861.
twalthr
added a commit
to twalthr/flink
that referenced
this pull request
Apr 23, 2018
…k to prevent data loss This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush. Negative effect: Existing checksums are not maintained anymore and thus become invalid. This closes apache#5861.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 5, 2018
…k to prevent data loss This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush. Negative effect: Existing checksums are not maintained anymore and thus become invalid. This closes apache#5861.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 5, 2018
…k to prevent data loss This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush. Negative effect: Existing checksums are not maintained anymore and thus become invalid. This closes apache#5861.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
…k to prevent data loss This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush. Negative effect: Existing checksums are not maintained anymore and thus become invalid. This closes apache#5861.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
…k to prevent data loss This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush. Negative effect: Existing checksums are not maintained anymore and thus become invalid. This closes apache#5861.
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…k to prevent data loss This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush. Negative effect: Existing checksums are not maintained anymore and thus become invalid. This closes apache#5861.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change replaces Hadoop's LocalFileSystem (which is a checksumming filesystem) with the RawFileSystem implementation. For performing checksums the default filesystem only flushes in 512 byte intervals which might lead to data loss during checkpointing. In order to guarantee exact results we skip the checksum computation and perform a raw flush.
Negative effect: Existing checksums are not maintained anymore and thus become invalid.
Brief change log
Verifying this change
Added a check for verifying the file length and file size.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation