[FLINK-2435] User-defined types in CsvReader #5862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Tuple and Row 'containers' while reading from a csv file
kenmy
reviewed
Apr 25, 2018
| @@ -89,14 +94,14 @@ | |||
| * the state of this parser. | |||
| * The start position within the byte array and the array's valid length is given. | |||
| * The content of the value is delimited by a field delimiter. | |||
| * | |||
ex00
suggested changes
Oct 1, 2018
There was a problem hiding this comment.
Hi @DmitryKober thanks for your work, I left a few comments about you changes.
| @PublicEvolving | ||
| public static <X extends Tuple> TupleTypeInfo<X> getTupleTypeInfo(Class<?>... incomeTypes) { | ||
| if (incomeTypes == null || incomeTypes.length == 0) { | ||
| throw new IllegalArgumentException(); |
There was a problem hiding this comment.
I think the good idea add here message for exception.
| @@ -129,7 +129,7 @@ protected TypeExtractor() { | |||
| // TypeInfoFactory registry | |||
| // -------------------------------------------------------------------------------------------- | |||
|
|
|||
| private static Map<Type, Class<? extends TypeInfoFactory>> registeredTypeInfoFactories = new HashMap<>(); | |||
| public static Map<Type, Class<? extends TypeInfoFactory>> registeredTypeInfoFactories = new HashMap<>(); | |||
|
|
||
| synchronized (CUSTOM_PARSERS) { | ||
| if (CUSTOM_PARSERS.containsKey(type)) { | ||
| LOG.warn("'{}' type is already registered with '{}' parser. Skipping."); |
There was a problem hiding this comment.
You don't provide arguments for format message to log.
| @@ -473,7 +534,7 @@ private static void appendTupleTypeGenerics(StringBuilder sb, int numFields) { | |||
| } | |||
|
|
|||
| private static final String HEADER = | |||
| "/*\n" | |||
| "/*\n" | |||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
|
|
||
| //CHECKSTYLE.OFF: AvoidStarImport|ImportOrder |
|
I'm closing this as "Abandoned", since there is no more activity and the code base has moved on quite a bit. Please re-open this if you feel otherwise and work should continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FLINK-2435] Provides the capability of specifying user-defined types in Tuple and Row 'containers' while reading from a csv file