[FLINK-8661] Replace Collections.EMPTY_MAP with Collections.emptyMap() #5864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does using Collections.EMPTY_MAP/EMPTY_SET lead to some warnings logging? |
|
Hi, @bowenli86 No. It wont gives warning logging, instead it will gives static compilation warning. |
|
Thanks @zentol 👍 |
|
merging. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 18, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 18, 2018
|
+1 |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 18, 2018
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Apr 18, 2018
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The use of Collections.EMPTY_SET and Collections.EMPTY_MAP often causes unchecked assignment. It should be replaced with Collections.emptySet() and Collections.emptyMap() .
Brief change log
Change Collections.EMPTY_MAP and Collections.EMPTY_LIST to Collections.emptyList() & Collections.emptyMap().
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.