[FLINK-8237] [BucketingSink] Better error message added #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhueske
reviewed
May 3, 2018
| @@ -550,6 +550,9 @@ private void openNewPartFile(Path bucketPath, BucketState<T> bucketState) throws | |||
| Path inProgressPath = getInProgressPathFor(partPath); | |||
| if (bucketState.writer == null) { | |||
| bucketState.writer = writerTemplate.duplicate(); | |||
| if (bucketState.writer == null) { | |||
| throw new RuntimeException("Could not duplicate writer."); | |||
There was a problem hiding this comment.
I would add the class name of the writerTemplate object and that the class needs to implement the Writer.duplicate() method.
|
Thanks for the PR @pavel-shvetsov-git! |
|
Message has been improved as suggested. |
|
Thanks for the update @pavel-shvetsov-git. |
|
merging |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
May 7, 2018
…er.duplicate returns null. This closes apache#5927.
asfgit
pushed a commit
that referenced
this pull request
May 7, 2018
…er.duplicate returns null. This closes #5927.
asfgit
pushed a commit
that referenced
this pull request
May 7, 2018
…er.duplicate returns null. This closes #5927.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 5, 2018
…er.duplicate returns null. This closes apache#5927.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 5, 2018
…er.duplicate returns null. This closes apache#5927.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
…er.duplicate returns null. This closes apache#5927.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
…er.duplicate returns null. This closes apache#5927.
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…er.duplicate returns null. This closes apache#5927.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added better error message as mentioned in issue description and comments.