Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8977] [e2e] End-to-end test for manual job resume after terminal failure #6004

Closed
wants to merge 10 commits into from

Conversation

tzulitai
Copy link
Contributor

What is the purpose of the change

This PR is based on new e2e features introduced by #5941, #5990, and #5969.
Only the last two commits are relevant to FLINK-8977.

This PR adds e2e test coverage for the case that after a terminal failure caused by the user job code, manually resuming from a retained checkpoint works correctly.

This is achieved by extending the test_resume_externalized_checkpoints.sh test script to accept a SIMULATE_FAILURE flag.

Brief change log

  • 9360ea9 Extend the general purpose DataStream job to allow configuring restart strategies.
  • b5d713c Extend test_resume_externalized_checkpoints.sh to allow simulating the job failure + manual resume case.

Verifying this change

Verifiable by running locally the following e2e test script:
SIMULATE_FAILURE=true flink-end-to-end-tests/test-scripts/test_resume_externalized_checkpoints.sh

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

tzulitai added a commit to tzulitai/flink that referenced this pull request May 18, 2018
@asfgit asfgit closed this in 97a6638 May 22, 2018
asfgit pushed a commit that referenced this pull request May 22, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants