Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9473] [table] Added new methods into ExternalCatalogSchema based on interface Schema changes in Calcite #6099

Closed
wants to merge 1 commit into from

Conversation

snuyanzin
Copy link
Contributor

What is the purpose of the change

Make Flink compilable after Calcite version bump to 1.17.0

Brief change log

  • new abstract methods dummy implementation
  • bump calcite version to 1.17.0-SNAPSHOT

Verifying this change

to verify need to check if it or compilable or not e.g.
mvn clean package -DskipTests

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable )

@fhueske
Copy link
Contributor

fhueske commented May 30, 2018

Thanks for the PR @snuyanzin!
We cannot update the Calcite version to a SNAPSHOT version and have to wait until Calcite 1.17 is released before continuing with this PR.

Best, Fabian

@snuyanzin
Copy link
Contributor Author

snuyanzin commented Jul 26, 2018

thank you for your comment. As Calcite 1.17.0 released and I found more things to be fixed especially relating to the test. As soon as I finished will mention all Calcite's tickets because of which some changes in Flink's code are required.
What is better? to close this PR and create a new one or continue here?

@twalthr twalthr changed the title [FLINK-9473][Table API & SQL] Added new methods into ExternalCatalogSchema based on interface Schema changes in Calcite [FLINK-9473] [table] Added new methods into ExternalCatalogSchema based on interface Schema changes in Calcite Jul 31, 2018
@twalthr
Copy link
Contributor

twalthr commented Aug 3, 2018

We can close this PR as this is covered by #6484.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants