Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9660] [mesos] Allow passing custom artifacts to Mesos workers #6207

Closed
wants to merge 1 commit into from

Conversation

lishim
Copy link
Contributor

@lishim lishim commented Jun 26, 2018

What is the purpose of the change

  • This pull request introduces a feature that allows passing custom artifact URIs to Mesos workers

Brief change log

  • A new parameter mesos.resourcemanager.tasks.uris was introduced

Verifying this change

This change added tests and can be verified as follows:

  • Added unit tests that verify correctness of behavior of new parameter
  • Manually verified behavior by running Flink in Mesos with Docker containerizer and 2 task managers. A private Docker registry was used for taskmanager Docker image. Confirmed that Mesos was unable to pull the image with default settings. After that, added mesos.resourcemanager.tasks.uris parameter with path to local archive containing Docker credentials configuration. Confirmed the file was extracted to local sandbox of taskmanager Mesos task, and Docker image was successfully pulled.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @lishim. The changes look good to me. Merging this PR.

@asfgit asfgit closed this in d2de75e Jun 30, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants