[FLINK-1925] Fixes blocking method submitTask on the TM #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into two phases: TDD reception with eager acknowledgement and TDD instantiation with a subsequent state update message.
tillrohrmann
changed the title
…ase timeouts for travis
| .description())); | ||
| } | ||
| } else { | ||
| if (!(success instanceof Messages.Acknowledge$)) { |
There was a problem hiding this comment.
I think this line is not parsable in Eclipse (the $ mess with the Java parser).
A workaround is to expose the case object class and object via a utility method and check against that.
|
Looks god modulo some comments. The most critical being the concurrent Map one. |
…n.concurrent.ConcurrentHashMap, refactors submitTask method into extra initializeTask method, makes message type test eclipse compatible.
|
Thanks for reviewing the code @StephanEwen. I addressed your comments and updated the PR. |
|
Looks good. Will merge this in my next batch, since I am building code on top anyways... |
bhatsachin
pushed a commit
to bhatsachin/flink
that referenced
this pull request
May 5, 2015
…e into two phases: 1. TDD reception with eager acknowledgement and 2. TDD instantiation with a subsequent state update message. This closes apache#622
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
…e into two phases: 1. TDD reception with eager acknowledgement and 2. TDD instantiation with a subsequent state update message. This closes apache#622
nltran
pushed a commit
to nltran/flink
that referenced
this pull request
Jan 8, 2016
…e into two phases: 1. TDD reception with eager acknowledgement and 2. TDD instantiation with a subsequent state update message. This closes apache#622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
submitTaskmethod which processes theSubmitTaskmessage blocks while downloading the task jars from theJobManager. Depending on the number of TMs and jars, this can take a long time.In order to get rid of the blocking call the
submitTaskmethod is split up into two phases: TDD reception with eager acknowledgement and TDD instantiation with a subsequent state update message. The TDD instantiation is executed concurrently in a future. Upon finishing the instantiation, anUpdateTaskExecutionStatemessage withExecutionState.RUNNINGis sent to the JM. This implies that the state of theExecutionis not directly set toRUNNINGby theSubmitTaskfuture handler which is created inExecution.deployToSlot.