[FLINK-9681] [table] Make sure difference between minRetentionTime and maxRetentionTime at least 5 minutes #6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d maxRetentionTime at least 5 minutes
fhueske
reviewed
Jul 5, 2018
There was a problem hiding this comment.
Hi @hequn8128, the PR looks good. I left two minor comments.
Best, Fabian
docs/dev/table/streaming.md
Outdated
|
|
||
| {% endhighlight %} | ||
| </div> | ||
| </div> | ||
|
|
||
| Configuring different minimum and maximum idle state retention times is more efficient because it reduces the internal book-keeping of a query for when to remove state. | ||
| Configuring different minimum and maximum idle state retention times is more efficient because it reduces the internal book-keeping of a query for when to remove state. Difference between minTime and maxTime shoud be at least 5 minutes. |
There was a problem hiding this comment.
The "... more efficient ..." does not apply anymore. Maybe rephrase to
Cleaning up state requires additional bookkeeping which becomes less expensive for larger differences of
minTimeandmaxTime. The difference betweenminTimeandmaxTimemust be at least 5 minutes.
| /** | ||
| * Test class used to test min and max retention time. | ||
| */ | ||
| class StreamQueryConfigTest(min: Time, max: Time) extends StreamQueryConfig { |
There was a problem hiding this comment.
I would rename the class to TestStreamQueryConfig because the Test at the end suggests that this class is testing something instead of being a util for a test.
|
@fhueske Comments have been addressed. Thanks for your review. |
|
Thanks for the update @hequn8128. I'll merge this |
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…Time and maxRetentionTime. This closes apache#6255.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to make sure difference between minRetentionTime and maxRetentionTime at least 5 minutes. Currently, for a group by(or other operators), if minRetentionTime equals to maxRetentionTime, the group by operator will register a timer for each record coming at different time which cause performance problem. The reasoning for having two parameters is that we can avoid to register many timers if we have more freedom when to discard state. As min equals to max cause performance problem it is better to make sure these two parameters are not same.
Brief change log
QueryConfigTestclass extends from StreamQueryConfig.QueryConfigTestdon't have the 5min limitation which makes test more convenient.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation