[FLINK-1922] Fixes NPE when TM receives a null input split #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| jobID, | ||
| vertexID, | ||
| executionID, | ||
| Thread.currentThread().getContextClassLoader(), |
There was a problem hiding this comment.
This is probably null, no? The default classloader can be grabbed either via. Classloader.getSystemClassloader() or here via getClass().getClassloader().
There was a problem hiding this comment.
This could be null. Would probably better to grab class loader via getClass I suppose.
|
I'll fix this and merge the pull request... |
|
Thanks for fixing this. On Tue, Apr 28, 2015 at 8:21 PM, Stephan Ewen notifications@github.com
|
bhatsachin
pushed a commit
to bhatsachin/flink
that referenced
this pull request
May 5, 2015
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
nltran
pushed a commit
to nltran/flink
that referenced
this pull request
Jan 8, 2016
pnowojski
pushed a commit
to pnowojski/flink
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TaskInputSplitProviderdid not handle null input splits which are wrapped into aNextInputSplitmessage properly. Fixed this.