Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9881] Fixed a typo in table.scala #6354

Closed
wants to merge 1 commit into from

Conversation

tygrash
Copy link

@tygrash tygrash commented Jul 17, 2018

@twalthr @pnowojski please review this small PR fixing a typo found while reading table api code.

What is the purpose of the change

  • function containsUnboudedUDTFCall in org.apache.flink.table.api.table.scala contains typo and should be containsUnboundedUDTFCall, so it is just an improvement in code readability.

Brief change log

  • function name changed from containsUnboudedUDTFCall to containsUnboundedUDTFCall in org.apache.flink.table.api.table.scala.
  • Does this pull request introduce a new feature? NO

@tygrash tygrash changed the title Fixed a typo in table.scala [FLINK-9881] Fixed a typo in table.scala Jul 17, 2018
@tisonkun
Copy link
Member

LGTM! It's a net win.

@twalthr
Copy link
Contributor

twalthr commented Jul 19, 2018

Thank you @tygrash. For future PRs please use the following schema for commits so that I don't have to touch them again:
"[FLINK-XXXX] [table] Issue message"
"[FLINK-XXXX] [sql-client] Issue message"
"[hotfix] [sql-client] Issue message"

@asfgit asfgit closed this in c5b3d17 Jul 19, 2018
asfgit pushed a commit that referenced this pull request Jul 19, 2018
asfgit pushed a commit that referenced this pull request Jul 19, 2018
@tisonkun
Copy link
Member

@twalthr thank you for the hint. I've updated my PRs #6353 #6345 #6339 as you suggested.

@tygrash
Copy link
Author

tygrash commented Jul 19, 2018

@twalthr I'll definitely take care of this in future. Thanks for guidance.

sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants