[FLINK-9912][JM] Release TaskExecutors if they have no slots registered at SlotPool #6394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
releaseTaskExecutors
branch
from
75fb9af
to
748c9c7
Compare
tillrohrmann
force-pushed
the
releaseTaskExecutors
branch
from
748c9c7
to
4b72e77
Compare
tillrohrmann
force-pushed
the
releaseTaskExecutors
branch
from
4b72e77
to
1ea396a
Compare
The SlotSharingManager is designed to be used by a single thread. Therefore, it is the responsibility of the caller to make sure that there is only a single thread at any given time accesssing this component. Consequently, the component does not need to be synchronized. This closes apache#6389.
…ed at SlotPool This commit extends the SlotPools behaviour when failing an allocation by sending a notification message to the TaskExecutor about the freed slot. Moreover, it checks whether the affected TaskExecutor has more slots registered or not. In the latter case, the TaskExecutor's connection will be eagerly closed. This closes apache#6394.
tillrohrmann
force-pushed
the
releaseTaskExecutors
branch
from
1ea396a
to
d50551d
Compare
kl0u
pushed a commit
to kl0u/flink
that referenced
this pull request
Sep 20, 2018
…ed at SlotPool This commit extends the SlotPools behaviour when failing an allocation by sending a notification message to the TaskExecutor about the freed slot. Moreover, it checks whether the affected TaskExecutor has more slots registered or not. In the latter case, the TaskExecutor's connection will be eagerly closed. This closes apache#6394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit extends the SlotPools behaviour when failing an allocation by sending a notification
message to the TaskExecutor about the freed slot. Moreover, it checks whether the affected
TaskExecutor has more slots registered or not. In the latter case, the TaskExecutor's connection
will be eagerly closed.
This PR is based on #6389.
Brief change log
freeSlotmessage to owningTaskExecutorof failedAllocatedSlotTaskExecutorconnection if it no longer has slots registered at theJobMasterVerifying this change
SlotPoolTest#testFreeFailedSlots,SlotPoolTest#testFailingAllocationFailsPendingSlotRequestsandJobMasterTest#testReleasingTaskExecutorIfNoMoreSlotsRegisteredDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation