Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9943] Support TaskManagerMetricQueryServicePaths msg in JobManager Actor #6429

Closed
wants to merge 1 commit into from
Closed

[FLINK-9943] Support TaskManagerMetricQueryServicePaths msg in JobManager Actor #6429

wants to merge 1 commit into from

Conversation

chuanlei
Copy link
Contributor

What is the purpose of the change

This pull request makes metric system be exposed to external akka client fully instead of only Jobmanager's metric*

Brief change log

  • Add RequestTaskManagerMetricQueryServicePaths message in JobManager actor
  • Add RequestTaskManagerMetricQueryServicePaths and TaskManagerMetricQueryServicePaths in JobMessages
  • *Refactor TaskManagerMetricQueryServicePaths's requestTaskManagerMetricQueryServicePaths method *

Verifying this change

This change added tests and can be verified as follows:

  • Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, WebRuntimeMonitor works correctly and external akka system can fetch metrics correctly

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@chuanlei
Copy link
Contributor Author

@twalthr could you please have a look for this pr?

we think flink should expose its metrics directly via jobmanager so that we can develop 3rd party ui.

@chuanlei
Copy link
Contributor Author

cc @zentol could you please have a look for this pr?

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @chuanlei. Have you seen that Flink already exposes the metrics via REST. I think we should not expose internal components like the MetricQueryService because it would expose implementation details. Thus, I would vote to close this PR and the corresponding issue if the REST interface gives you what you need.

@isunjin
Copy link
Contributor

isunjin commented Oct 11, 2018

could you also close the JIRA? @chuanlei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants