[Backport 1.6][FLINK-10001][docs] Update Docker and Kubernetes documentation #6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
extendK8sDocumentation16
branch
5 times, most recently
from
0eb61b2
to
83f5875
Compare
tillrohrmann
force-pushed
the
extendK8sDocumentation16
branch
from
83f5875
to
b44c8d9
Compare
GJL
approved these changes
Aug 16, 2018
docs/ops/deployment/kubernetes.md
Outdated
| * a Deployment for a single Jobmanager | ||
| * a Deployment for a pool of Taskmanagers | ||
| * a Service exposing the Jobmanager's RPC and UI ports | ||
| <div class="alert alert-info"> |
There was a problem hiding this comment.
I'd use
<div class="alert alert-info" markdown="span">
<strong>Note:</strong> If using MiniKube please make sure to execute `minikube ssh 'sudo ip link set docker0
promisc on'` before deploying a Flink cluster. Otherwise Flink components are not able to self reference
themselves through a Kubernetes service.
</div>
to make sure that the formatting is always consistent.
`...` compiles to <code class="highlighter-rouge">...</code> in our current setup.
docs/ops/deployment/kubernetes.md
Outdated
|
|
||
| The Flink job cluster image needs to contain the user code jars of the job for which the cluster is started. | ||
| Therefore, one needs to build a dedicated container image for every job. | ||
| Please follow these [instructions]({{ site.baseurl }}/ops/deployment/docker.html#docker-images-1). |
There was a problem hiding this comment.
One could link to https://github.com/apache/flink/blob/release-1.6/flink-container/docker/README.md#build directly. docker.html#docker-images-1 doesn't add much information.
There was a problem hiding this comment.
true, will change it.
tillrohrmann
force-pushed
the
extendK8sDocumentation16
branch
from
b44c8d9
to
67943a2
Compare
|
Thanks for the review @GJL. I've addressed your comments. |
|
I think it's good to go. |
asfgit
pushed a commit
that referenced
this pull request
Aug 17, 2018
…ocker and K8s [FLINK-10001][docs] Add documentation for job cluster deployment on K8s This closes #6562.
|
Manually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Backport of #6561 for
release-1.6.This PR updates Flink's Docker and Kubernetes documentation to include the job mode for containers. Moreover, it introduces a new github_branch markdown variable which can be used to reference the corresponding Github branch.
cc @GJL, @azagrebin
Verifying this change
Tested documentation manually
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation