Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-10154] [kinesis connector] Make sure we always read at least one record in Kinesis Connector. #6564

Closed
wants to merge 1 commit into from

Conversation

jgrier
Copy link
Member

@jgrier jgrier commented Aug 15, 2018

What is the purpose of the change

Fixing a bug that can cause the Kinesis Connector to request zero records and therefore throw an exception.

Brief change log

One line fix to ensure a minimum Kinesis request size of 1 record.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@bowenli86
Copy link
Member

+1

@StefanRRichter
Copy link
Contributor

LGTM 👍 Merging.

@asfgit asfgit closed this in b34ee94 Aug 16, 2018
asfgit pushed a commit that referenced this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants