[FLINK-10259] [table] Fix key extraction for GroupWindows. #6641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hequn8128
reviewed
Sep 2, 2018
|
|
||
| import scala.collection.JavaConverters._ | ||
|
|
||
| class InsertIntoITCase extends AbstractTestBase { |
There was a problem hiding this comment.
extends StreamingWithStateTestBase?
| class InsertIntoITCase extends AbstractTestBase { | ||
|
|
||
| @Test | ||
| def testInsertIntoAppendStreamToTableSink(): Unit = { |
There was a problem hiding this comment.
Since we have this test case, should we remove the testInsertIntoMemoryTable in SqlITCase ? It seems the two test cases are very similar.
| "Received retraction messages for append only table", | ||
| results.exists(!_.f0)) | ||
|
|
||
| val retracted = RowCollector.upsertResults(results, Array(0, 1, 2)).sorted |
There was a problem hiding this comment.
Array(0, 1, 2) -> Array(0, 1)
twalthr
changed the title
|
Thanks for the review @hequn8128! |
|
Thanks for the update @fhueske . Looks good to me. +1 to merge |
|
Thanks for the review @hequn8128! Merging |
kl0u
pushed a commit
to kl0u/flink
that referenced
this pull request
Sep 20, 2018
…indows. This closes apache#6641.
Clarkkkkk
pushed a commit
to Clarkkkkk/flink
that referenced
this pull request
Mar 7, 2019
…indows. This closes apache#6641. (cherry picked from commit f28b829)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes the key validation for SQL queries with group window aggregates that are emitted to an
UpsertStreamTableSink.Brief change log
INSERT INTOof different result types to different types of table sinks.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation