[FLINK-10324] Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
removeGetAllSortedByNameAndLock
branch
from
b582310
to
7d4f419
Compare
tillrohrmann
force-pushed
the
removeGetAllSortedByNameAndLock
branch
from
7d4f419
to
8c50222
Compare
|
Looks good. |
|
LGMT 👍 |
…Lock by getAllAndLock In order to reduce code duplication this commit replaces ZooKeeperStateHandleStore# getAllSortedByNameAndLock by getAllAndLock and do the sorting of the entries afterwards. The implication of this change is that we no longer try to release and remove corrupted entries and instead simply ignore them.
…NameAndLock by getAllAndLock
tillrohrmann
force-pushed
the
removeGetAllSortedByNameAndLock
branch
from
8c50222
to
47645e1
Compare
asfgit
pushed a commit
that referenced
this pull request
Sep 19, 2018
…Lock by getAllAndLock In order to reduce code duplication this commit replaces ZooKeeperStateHandleStore# getAllSortedByNameAndLock by getAllAndLock and do the sorting of the entries afterwards. The implication of this change is that we no longer try to release and remove corrupted entries and instead simply ignore them. This closes #6681.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In order to reduce code duplication this commit replaces ZooKeeperStateHandleStore#
getAllSortedByNameAndLock by getAllAndLock and do the sorting of the entries afterwards.
The implication of this change is that we no longer try to release and remove corrupted
entries and instead simply ignore them.
Verifying this change
Covered by existing
ZooKeeperStateHandleStoretestsDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation