Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-10414][cep] Added skip to next strategy #6756

Merged
merged 2 commits into from Oct 1, 2018

Conversation

dawidwys
Copy link
Contributor

What is the purpose of the change

This pull request adds support of SKIP_TO_NEXT, which will fully cover all variants of AFTER MATCH clause in SQL. This clause is important for e.g. reluctant quantifiers at the end, as after first, shortest match, all others started at the same element will be discarded.

Brief change log

  • Added SkipToNextStrategy
  • Extended documentation with SKIP_TO_NEXT description

Verifying this change

This change added tests and can be verified as follows:

  • org.apache.flink.cep.nfa.AfterMatchSkipITCase#testNoSkipWithQuantifierAtTheEnd
  • org.apache.flink.cep.nfa.AfterMatchSkipITCase#testSkipToNextWithQuantifierAtTheEnd
  • org.apache.flink.cep.nfa.AfterMatchSkipITCase#testNoSkipWithFollowedByAny
  • org.apache.flink.cep.nfa.AfterMatchSkipITCase#testSkipToNextWithFollowedByAny

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@dawidwys dawidwys changed the title [FLINK-10414] Added skip to next strategy [FLINK-10414][cep] Added skip to next strategy Sep 25, 2018
Copy link
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I would recommend to put the common code of the SkipPastLast with the SkipToNext to a SkipRelativeToPrevMatchStrategy class and have the two strategies above extend that base. This is because the two classes share almost all of their code.

After this, feel free to merge @dawidwys !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants