Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-10798] Add the version number of Flink 1.7 to MigrationVersion #7026

Closed
wants to merge 1 commit into from

Conversation

yanghua
Copy link
Contributor

@yanghua yanghua commented Nov 6, 2018

What is the purpose of the change

Add the version number of Flink 1.7 to MigrationVersion

Brief change log

  • Add the version number of Flink 1.7 to MigrationVersion

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@yanghua
Copy link
Contributor Author

yanghua commented Nov 6, 2018

@tzulitai @zentol

@zentol
Copy link
Contributor

zentol commented Nov 6, 2018

I would not merge this right now, as it encourages people to update tests now when this should only be done once 1.7 is released.

@tzulitai
Copy link
Contributor

tzulitai commented Nov 6, 2018

Agreed, we should only merge this after 1.7 is released.

@yanghua
Copy link
Contributor Author

yanghua commented Nov 30, 2018

Since Flink 1.7 has released, shall we merge this PR?

@yanghua
Copy link
Contributor Author

yanghua commented Nov 30, 2018

cc @tillrohrmann

@tzulitai
Copy link
Contributor

tzulitai commented Dec 3, 2018

+1 LGTM, will merge this now.

@asfgit asfgit closed this in 9956bc7 Dec 3, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Dec 6, 2018
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants