Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Update nightly master cron jobs #7045

Closed
wants to merge 7 commits into from

Conversation

twalthr
Copy link
Contributor

@twalthr twalthr commented Nov 7, 2018

What is the purpose of the change

This PR updates the nightly master cron jobs to be in sync with the available end-to-end tests.

Brief change log

  • Missing end-to-end tests added
  • Redundant end-to-end tests removed

Verifying this change

Not verified yet as builds are failing. We might need to further stabilize the tests and might further split the misc tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@twalthr twalthr requested a review from zentol November 7, 2018 15:27
@zentol zentol self-assigned this Nov 7, 2018
@@ -43,12 +43,16 @@ echo "Flink distribution directory: $FLINK_DIR"

# run_test "<description>" "$END_TO_END_DIR/test-scripts/<script_name>"

run_test "Flink CLI end-to-end test" "$END_TO_END_DIR/test-scripts/test_cli.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update split_misc_hadoopfree to include all tests independent of hadoop. I've copied split_misc.sh for now since it's the easiest&fastest option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will copy some tests but I think we need to further split split_misc_hadoopfree because we run out of time otherwise.

nightly.sh Outdated
@@ -43,7 +43,7 @@ mkdir -p $ARTIFACTS_DIR || { echo "FAILURE: cannot create log directory '${ARTIF
LOG4J_PROPERTIES=${FLINK_DIR}/tools/log4j-travis.properties

MVN_LOGGING_OPTIONS="-Dlog.dir=${ARTIFACTS_DIR} -Dlog4j.configuration=file://$LOG4J_PROPERTIES -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
MVN_COMMON_OPTIONS="-nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -Dfast"
MVN_COMMON_OPTIONS="-T1C -nsu -B -Dflink.forkCount=2 -Dflink.forkCountTestPackage=2 -Dfast"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in MVN_COMPILE_OPTIONS instead?

Copy link
Contributor

@zentol zentol Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise we're executing (java) e2e tests in parallel

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split_misc_hadoopfree still contains the kubernetes test.

@twalthr
Copy link
Contributor Author

twalthr commented Nov 14, 2018

Thanks @zentol. I will remove the kubernetes test and merge this. Once Travis gives green light.

@twalthr
Copy link
Contributor Author

twalthr commented Nov 14, 2018

The changes have been applied to cron-master-e2e and cron-1.7-e2e.

@twalthr twalthr closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants