[FLINK-10848][YARN] properly remove YARN ContainerRequest upon container allocation success #7078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suez1224
force-pushed
the
removeContainerRequest
branch
2 times, most recently
from
61d6c05
to
1053b2b
Compare
…r and YarnResourceManager
suez1224
force-pushed
the
removeContainerRequest
branch
from
1053b2b
to
567d69b
Compare
kien-truong
reviewed
Dec 14, 2018
| @@ -438,6 +438,8 @@ private void containersAllocated(List<Container> containers) { | |||
| numPendingContainerRequests = Math.max(0, numPendingContainerRequests - 1); | |||
| LOG.info("Received new container: {} - Remaining pending container requests: {}", | |||
| container.getId(), numPendingContainerRequests); | |||
| resourceManagerClient.removeContainerRequest(new AMRMClient.ContainerRequest( | |||
There was a problem hiding this comment.
Is this safe to create a new container request object ? Maybe we should call getMatchingRequests and remove one of the returned results.
There was a problem hiding this comment.
getMatchingRequests only filter on priority, resourceName, capability. However, ContainerRequest also contains racks, nodes information.
fatjoshua
reviewed
Jan 2, 2019
| @@ -361,7 +361,8 @@ public void onContainersAllocated(List<Container> containers) { | |||
| "Received new container: {} - Remaining pending container requests: {}", | |||
| container.getId(), | |||
| numPendingContainerRequests); | |||
|
|
|||
| resourceManagerClient.removeContainerRequest(new AMRMClient.ContainerRequest( | |||
There was a problem hiding this comment.
maybe we can move this removeContainerRequest before this for loop, use a indepedent for loop to do this remove staff.
Suggested change
| resourceManagerClient.removeContainerRequest(new AMRMClient.ContainerRequest( | |
| resourceManagerClient.removeContainerRequest(new AMRMClient.ContainerRequest( |
|
Thanks a lot for all the reviews. We've tested the branch in production for some time, merging into the master now. |
asfgit
pushed a commit
that referenced
this pull request
Jan 5, 2019
…ner allocation success This closes #7078
asfgit
pushed a commit
that referenced
this pull request
Jan 5, 2019
…ner allocation success This closes #7078
JTaky
pushed a commit
to JTaky/flink
that referenced
this pull request
Jan 14, 2019
…ner allocation success This closes apache#7078
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
…ner allocation success This closes apache#7078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Properly remove YARN ContainerRequest upon container allocation success.
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation