[FLINK-11089]Log filecache directory removed messages #7257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tillrohrmann Hi,are you available to help me to review this PR? Thanks! Look forwards to your reply. |
1 similar comment
|
@tillrohrmann Hi,are you available to help me to review this PR? Thanks! Look forwards to your reply. |
rmetzger
reviewed
Feb 13, 2019
| } | ||
| catch (IOException e) { | ||
| LOG.error("File cache could not properly clean up storage directory."); | ||
| LOG.error("File cache could not properly clean up storage directory: " + dir, e); |
There was a problem hiding this comment.
Suggested change
| LOG.error("File cache could not properly clean up storage directory: " + dir, e); | |
| LOG.error("File cache could not properly clean up storage directory: {}", dir, e); |
liu-zhaokun
force-pushed
the
mastercleandistcache
branch
from
39ac83a
to
a70a39c
Compare
|
@rmetzger Thanks for your reply.I have update the patch,could help me to review it? |
tillrohrmann
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
Thanks for you contribution @liu-zhaokun. I had a single comment. After addressing this comment, it can be merged.
@flinkbot approve all
flink-runtime/src/main/java/org/apache/flink/runtime/filecache/FileCache.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FLINK-11089
When taskmanager exit or shutdown,the filecache directory named "flink-dist-cache*" will be removed,but there is not any log about this action.So I think we should log it for user to check it easy when there are some bugs.
You can see IOManager.java logs the removed messages when taskmanager shutdown, filecache can do the same things.