[FLINK-11144][tests] Make Tests runnable on Java 9 #7293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
requested changes
Dec 12, 2018
pom.xml
Outdated
| @@ -1602,7 +1616,7 @@ under the License. | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-shade-plugin</artifactId> | |||
| <version>3.0.0</version> | |||
| <version>3.1.1</version> | |||
There was a problem hiding this comment.
please move this into the jdk9 profile; I don't have the time right now to verify that the shading still works correctly for all modules.
|
Note that I would propose changing the commit and JIRA title as the current one implies that we've already dealt with all issues preventing tests to complete successfully. |
GJL
changed the title
GJL
changed the title
GJL
changed the title
|
Thanks for reviewing, @zentol. Merging. |
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
This enables to run tests on Java 9. However, not all tests are passing at the moment. This closes apache#7293.
|
With this change, I failed the building. |
|
@jinxing64 If you haven't already done so, please create an issue in jira with more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Make tests run on Java 9 by upgrading plugins to minimum supported version for Java 9: https://cwiki.apache.org/confluence/display/MAVEN/Java+9+-+Jigsaw
cc: @zentol
Brief change log
Verifying this change
This change is already covered by existing tests, such as all tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation