Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11173][table] Fix the exception message of proctime attribute validation in TableSourceUtil#validateTableSource #7374

Closed
wants to merge 1 commit into from

Conversation

wenhuitang
Copy link
Contributor

What is the purpose of the change

This pull request makes the exception message of proctime attribute validation in TableSourceUtil#validateTableSource correct.

Brief change log

The exception message of proctime attribute validation in TableSourceUtil#validateTableSource was changed from "Found a RowtimeAttributeDescriptor for " to "Found a processing time attribute: ".

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

…validation in TableSourceUtil#validateTableSource
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wenhuitang. Merging...

asfgit pushed a commit that referenced this pull request Jan 4, 2019
…validation in TableSourceUtil#validateTableSource

This closes #7374.
@asfgit asfgit closed this in c09dc96 Jan 4, 2019
asfgit pushed a commit that referenced this pull request Jan 4, 2019
…validation in TableSourceUtil#validateTableSource

This closes #7374.
JTaky pushed a commit to JTaky/flink that referenced this pull request Jan 14, 2019
…validation in TableSourceUtil#validateTableSource

This closes apache#7374.
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
…validation in TableSourceUtil#validateTableSource

This closes apache#7374.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants