[FLINK-11256] Replace the reference of StreamNode object with ID in S… #7403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…treamEdge to reduce the sizes of JobGraph and TDD
There was a problem hiding this comment.
Thanks for the PR. @sunhaibotb
I only left two suggestions. And please let me know your opinion :)
Bests,
Jincheng
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
Show resolved
Hide resolved
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
Outdated
Show resolved
Hide resolved
|
Hi @sunhaibotb Thanks for the update! |
|
Thank @sunjincheng121 for the review. |
sunjincheng121
pushed a commit
to sunjincheng121/flink
that referenced
this pull request
Jan 18, 2019
…bGraph This closes apache#7403 Add operatorName information to the method toString() of StreamEdge add comments for sourceOperatorName and targetOperatorName
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request replaces the reference of StreamNode object with ID in StreamEdge to reduce the sizes of JobGraph and TDD. Those referenced objects including sourceVertex and targetVertex will be written transitively on serializing StreamEdge, but they are not needed in JM and Task. For a large size topology, this will causes JobGraph and TDD to become much larger than that actually need, and more likely to occur rpc timeout when transmitted.
Brief change log
Verifying this change
This change is already covered by existing tests, such as StreamGraphGeneratorTest, StreamingJobGraphGeneratorTest, etc.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation