[FLINK-11167][runtime] Optimize RocksDBListState#Put by removing the clear before put operation when input is not empty #7421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the failed tests are relevant, I'll dig into it. |
|
Hi @klion26, the failing test is actually caused by this: https://issues.apache.org/jira/browse/FLINK-11280. It shouldn't be relevant to your changes here, but I suggest to rebase again after we have a fix for FLINK-11280 in just to be safe. |
|
@tzulitai thank you for your quick reply. I'll rebase it after the problem have been fixed. |
|
FLINK-11280 is fixed and merged to master now. |
…clear before put operation Differential Revision: https://aone.alibaba-inc.com/code/D816268
klion26
force-pushed
the
FLINK-11167_OptimizeRocksDBListStatePut
branch
from
1148f26
to
45d7ce5
Compare
|
@tzulitai thank you for the feedback, I've rebased master and retriggered Travis again. |
|
hi, @tzulitai can you help to review this pr please |
tianchen92
pushed a commit
to tianchen92/flink
that referenced
this pull request
May 13, 2019
…ore every put operation This closes apache#7421. Differential Revision: https://aone.alibaba-inc.com/code/D816268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request adjusts the clear's position in function
updateInternal, so when the inputvaluesis not empty, we do not need to call the clear operation.Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation