[FLINK-11292][doc] Update document about how to use new CompositeType… #7475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SerializerSnapshot
|
I'm not sure whether the updated part of document is enough for users, @tzulitai please feel free to add any comments if you think more details should be provided within this doc or anything else to improve. |
tzulitai
requested changes
Jan 15, 2019
| the snapshot of the most outer serializer should also contain snapshots of the nested serializers. | ||
|
|
||
| The `CompositeSerializerSnapshot` can be used specifically for this scenario. It wraps the logic of resolving | ||
| `CompositeTypeSerializerSnapshot` could be extended for all nested `TypeSerializer`s in this scenario. It wraps the logic of resolving |
There was a problem hiding this comment.
This sentence is a bit strange (the "for all nested TypeSerializer" part).
I would like to stick with the original sentence ("could be used specifically for this scenario").
|
refactored according to your comments @tzulitai |
alpinegizmo
requested changes
Jan 18, 2019
|
@alpinegizmo Thanks for your patient and kind review! Already refactored doc according to your comments. |
tzulitai
added a commit
to tzulitai/flink
that referenced
this pull request
Feb 20, 2019
… to a top-level subsection This commit adds an independent, top-level subsection named "Predefined convenient TypeSerializerSnapshot classes" to the "Custom Serialization for Managed State" page. This section covers details about using the SimpleTypeSerializerSnapshot and CompositeTypeSerializerSnapshot classes, what they do, and in which cases they are suitable to be used by a serializer. This closes apache#7475.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request update document how to use the new
CompositeTypeSerializerSnapshot.Brief change log
custom_serialization.mdof newCompositeTypeSerializerSnapshot.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation