[FLINK-10774] Rework lifecycle management of partitionDiscoverer in FlinkKafkaConsumerBase #7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzulitai
approved these changes
Jan 31, 2019
There was a problem hiding this comment.
Since I've already reviewed this as part of the efforts in #7020, and Travis is green, LGTM +1 👍
Thanks for fixing this @stevenzwu @tillrohrmann
|
Thanks for the review @tzulitai. Merging. |
…linkKafkaConsumerBase
…cle verifications
…before closed when concurrently accessed
…LifeCycle Split #testConsumerLifeCycle into two methods which represent the two if-else branches. This closes apache#7606.
tillrohrmann
force-pushed
the
FLINK-10774
branch
from
afea47e
to
2fd4549
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Jan 31, 2019
…LifeCycle Split #testConsumerLifeCycle into two methods which represent the two if-else branches. This closes apache#7606.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Jan 31, 2019
…LifeCycle Split #testConsumerLifeCycle into two methods which represent the two if-else branches. This closes apache#7606.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Jan 31, 2019
…LifeCycle Split #testConsumerLifeCycle into two methods which represent the two if-else branches. This closes apache#7606.
|
Failing test case is unrelated. |
|
@tillrohrmann sorry for a late question. you mentioned In production/distributed environment, when a job restart due to exception from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR reworks the lifecycle management of the
FlinkKafkaConsumerBase#partitionDiscoverersuch that it will always be closed in theclose()method. This implies that all users of this class need to callclose()in order to properly clean up resources.cc @stevenzwu @tzulitai
Brief change log
partitionDiscovererfrom#runmethodFlinkKafkaConsumerBase#canceland#closesuch that cancel is non blocking andclosewill release all required resourcesVerifying this change
FlinkKafkaConsumerBaseTest#testClosePartitionDiscovererWhenOpenThrowException,#testClosePartitionDiscovererWhenCreateKafkaFetcherFails,#testClosePartitionDiscovererWhenKafkaFetcherFailsand#testClosePartitionDiscovererWithCancellationDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation