Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11522][table] Deprecate ExternalCatalogTable.builder() #7650

Closed

Conversation

dianfu
Copy link
Contributor

@dianfu dianfu commented Feb 4, 2019

What is the purpose of the change

This pull request deprecates the method ExternalCatalogTable.builder() in 1.8

Brief change log

  • Deprecate the method ExternalCatalogTable.builder() in 1.8

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 4, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ✅ 4. The [architecture] is sound.
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@dianfu
Copy link
Contributor Author

dianfu commented Feb 5, 2019

@twalthr Could you help to take a look at this quick PR? Thanks a lot.

@twalthr
Copy link
Contributor

twalthr commented Feb 5, 2019

@flinkbot approve all

Thanks @dianfu. Merging...

@asfgit asfgit closed this in e55fa94 Feb 5, 2019
dianfu added a commit to dianfu/flink that referenced this pull request Feb 6, 2019
This unblocks the porting and moving of ExternalCatalogTable to
flink-table-common for FLINK-11067.

This closes apache#7650
@dianfu dianfu deleted the deprecate_externalcatalogtable_builder branch June 10, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants