Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11544] Add jobId to JarRequestBody #7670

Merged
merged 4 commits into from
Feb 14, 2019

Conversation

uce
Copy link
Contributor

@uce uce commented Feb 8, 2019

What is the purpose of the change

  • This PR adds the optional jobId entry to JarRequestBody
    • If specified, users manually set the job ID of a job when submitting a JAr
    • If not specified, we keep the current behavior

Brief change log

  • Add jobId to JarRequestBody
  • Parse jobId when generating JobGraph

Verifying this change

  • This change added unit tests for added functionality
  • If you want to manually verify this change, you can follow these steps:
    1. Build this branch
    2. Upload examples/streaming/TopSpeedWindowing.jar via web UI
    3. Get $jarId from /v1/jars endpoint
    4. Execute curl -X POST -d '{}' http://localhost:8081/v1/jars/$jarId/run (expected: random job ID)
    5. Execute curl -X POST -d '{"jobId": "4\. fd72014d4c864993a2e5a9287b4a9c5d"}' http://localhost:8081/v1/jars/$jarId/run (expected: job ID fd72014d4c864993a2e5a9287b4a9c5d)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes (adds new field in request body of a v1 REST API endpoint)
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • I didn't add any documentation as I assume that the REST API docs are auto generated (@zentol please correct me if I'm wrong)

@uce
Copy link
Contributor Author

uce commented Feb 8, 2019

CC @yanghua @zentol

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 8, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❌ 1. The [description] looks good.
  • ❌ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ❌ 4. The change fits into the overall [architecture].
  • ❌ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the rest api docs, apart from that +1.
@flinkbot approve all

@uce uce force-pushed the flink_11544-set_job_id_rest_api branch from c3e2b7c to 1567678 Compare February 12, 2019 09:07
@uce
Copy link
Contributor Author

uce commented Feb 12, 2019

@zentol Thanks for the review. I rebased on master, regenerated the docs, and I am now waiting for Travis to complete before merging this.

@zentol zentol self-assigned this Feb 12, 2019
@zentol
Copy link
Contributor

zentol commented Feb 12, 2019

When merging, please update the commit component tag to [rest]

@uce uce force-pushed the flink_11544-set_job_id_rest_api branch from 1567678 to c38b81a Compare February 13, 2019 07:44
@rmetzger
Copy link
Contributor

I will merge this PR

@rmetzger rmetzger merged commit 79905ea into apache:master Feb 14, 2019
@uce uce deleted the flink_11544-set_job_id_rest_api branch May 19, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants