-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-11544] Add jobId to JarRequestBody #7670
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please regenerate the rest api docs, apart from that +1.
@flinkbot approve all
c3e2b7c
to
1567678
Compare
@zentol Thanks for the review. I rebased on master, regenerated the docs, and I am now waiting for Travis to complete before merging this. |
When merging, please update the commit component tag to |
1567678
to
c38b81a
Compare
I will merge this PR |
What is the purpose of the change
jobId
entry toJarRequestBody
Brief change log
jobId
toJarRequestBody
jobId
when generatingJobGraph
Verifying this change
examples/streaming/TopSpeedWindowing.jar
via web UI$jarId
from/v1/jars
endpointcurl -X POST -d '{}' http://localhost:8081/v1/jars/$jarId/run
(expected: random job ID)curl -X POST -d '{"jobId": "4\. fd72014d4c864993a2e5a9287b4a9c5d"}' http://localhost:8081/v1/jars/$jarId/run
(expected: job IDfd72014d4c864993a2e5a9287b4a9c5d
)Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yes (adds new field in request body of a v1 REST API endpoint)Documentation