Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-10569] Remove Instance usage in ExecutionVertexCancelTest #7723

Merged

Conversation

tisonkun
Copy link
Member

What is the purpose of the change

This pr is based on #7719 for the convenient constructor. The last commit is the diff.

Port CancelSequenceActorGateway to CancelSequenceSimpleAckingTaskManagerGateway and replace Instance->SimpleSlot with TestingLogicalSlot(TaskManagerGateway)

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector:(no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

cc @tillrohrmann @zentol

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❌ 1. The [description] looks good.
  • ❌ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ❌ 4. The change fits into the overall [architecture].
  • ❌ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@tisonkun tisonkun force-pushed the FLINK-10569-ExecutionVertexCancelTest branch from d324b2b to 351db86 Compare February 17, 2019 14:05
@zentol zentol self-assigned this Feb 20, 2019
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flinkbot approve all

1 comment, looks good otherwise.

@tisonkun tisonkun force-pushed the FLINK-10569-ExecutionVertexCancelTest branch 2 times, most recently from 115e8b3 to 543b03f Compare February 20, 2019 18:58
@zentol zentol force-pushed the FLINK-10569-ExecutionVertexCancelTest branch from 543b03f to 3477c28 Compare February 21, 2019 11:59
@zentol zentol merged commit c54d9a6 into apache:master Feb 22, 2019
@tisonkun tisonkun deleted the FLINK-10569-ExecutionVertexCancelTest branch February 22, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants