Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11690][runtime] Use configured RPC timeout in MiniCluster #7788

Merged
merged 1 commit into from Feb 22, 2019

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Feb 21, 2019

What is the purpose of the change

The MiniCluster uses a fixed timeout of 10 seconds instead of the timeout defined in the given MiniClusterConfiguration. This PR changes the constructor to respect the configured RPC timeout.

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 21, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@tillrohrmann tillrohrmann self-assigned this Feb 21, 2019
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @zentol. +1 for merging.

@tillrohrmann
Copy link
Contributor

@flinkbot approve all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants