Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER #7862

Closed
wants to merge 1 commit into from

Conversation

leesf
Copy link
Contributor

@leesf leesf commented Feb 28, 2019

What is the purpose of the change

Document CLI ignores -m parameter if high-availability is ZOOKEEPER in flink-conf.yaml.

Brief change log

Document CLI ignores -m parameter if high-availability is ZOOKEEPER in flink-conf.yaml.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@leesf
Copy link
Contributor Author

leesf commented Feb 28, 2019

cc @GJL

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 28, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

docs/ops/cli.md Outdated
@@ -270,7 +270,9 @@ Action "run" compiles and runs a program.
which to connect. Use this flag to
connect to a different JobManager than
the one specified in the
configuration.
configuration. It will be ignored if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this section is generated by the client, and thus the changes must be made to the respective classes. Not sure which though.

@zentol
Copy link
Contributor

zentol commented Feb 28, 2019

Also, why did you opt for updating the docs instead of making -m take precedence?

@leesf
Copy link
Contributor Author

leesf commented Mar 2, 2019

@zentol thanks for your advice. I will start making -m take precedence.

@leesf
Copy link
Contributor Author

leesf commented Apr 6, 2019

@flinkbot cc @zentol @GJL , could you please review this PR when you have time. Thanks

@aljoscha
Copy link
Contributor

There are some more comments on the Jira issue: https://issues.apache.org/jira/browse/FLINK-11779

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 29, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@aljoscha
Copy link
Contributor

Closing this PR since the result of the discussion on the Jira issue is to change the documentation and don't change the behaviour.

@aljoscha aljoscha closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants