New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER #7862
Conversation
cc @GJL |
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
docs/ops/cli.md
Outdated
@@ -270,7 +270,9 @@ Action "run" compiles and runs a program. | |||
which to connect. Use this flag to | |||
connect to a different JobManager than | |||
the one specified in the | |||
configuration. | |||
configuration. It will be ignored if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK this section is generated by the client, and thus the changes must be made to the respective classes. Not sure which though.
Also, why did you opt for updating the docs instead of making |
@zentol thanks for your advice. I will start making -m take precedence. |
There are some more comments on the Jira issue: https://issues.apache.org/jira/browse/FLINK-11779 |
Closing this PR since the result of the discussion on the Jira issue is to change the documentation and don't change the behaviour. |
What is the purpose of the change
Document CLI ignores -m parameter if high-availability is ZOOKEEPER in flink-conf.yaml.
Brief change log
Document CLI ignores -m parameter if high-availability is ZOOKEEPER in flink-conf.yaml.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation