New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-11790][table-planner-blink] Introduce FlinkRelNode interface and FlinkConventions #7878
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.flink.table.plan.nodes.physical |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this class to upper dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but i think this should belong to table-planner-blink
, right? The commit message and title seems to be inaccurate.
…nd FlinkConventions
Thanks a lot for the review @KurtYoung . Those class is only belong to |
Looks like the commit message have not changed. I will change it while merging... |
…nd FlinkConventions This closes apache#7878
What is the purpose of the change
Introduce basic Flink RelNode interface
Brief change log
Verifying this change
This change only contains interface definition, without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation