Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11790][table-planner-blink] Introduce FlinkRelNode interface and FlinkConventions #7878

Closed
wants to merge 1 commit into from

Conversation

godfreyhe
Copy link
Contributor

What is the purpose of the change

Introduce basic Flink RelNode interface

Brief change log

  • Define Flink RelNode inheritance structure
  • Define FlinkConventions

Verifying this change

This change only contains interface definition, without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 1, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

* limitations under the License.
*/

package org.apache.flink.table.plan.nodes.physical
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this class to upper dir?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Contributor

@KurtYoung KurtYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i think this should belong to table-planner-blink, right? The commit message and title seems to be inaccurate.

@godfreyhe godfreyhe changed the title [FLINK-11790][table-runtime-blink] Introduce basic Flink RelNode interface [FLINK-11790][table-runtime-blink] Introduce FlinkRelNode interface and FlinkConventions Mar 2, 2019
@godfreyhe
Copy link
Contributor Author

Thanks a lot for the review @KurtYoung . Those class is only belong to table-planner-blink now. I have update the commit message.

@KurtYoung KurtYoung changed the title [FLINK-11790][table-runtime-blink] Introduce FlinkRelNode interface and FlinkConventions [FLINK-11790][table-planner-blink] Introduce FlinkRelNode interface and FlinkConventions Mar 2, 2019
@KurtYoung
Copy link
Contributor

Looks like the commit message have not changed. I will change it while merging...

@KurtYoung KurtYoung closed this in e3248d8 Mar 2, 2019
HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
@godfreyhe godfreyhe deleted the FLINK-11790 branch June 1, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants