Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11833] [State Backends] Cleanup unnecessary createKeyedStateBackend methods in StateBackend #7909

Merged
merged 1 commit into from Mar 6, 2019

Conversation

carp84
Copy link
Member

@carp84 carp84 commented Mar 6, 2019

What is the purpose of the change

This PR is a simple cleanup of StateBackend interface

Brief change log

Removed unnecessary createKeyedStateBackend methods and completed the javadoc for the left one.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
    • Removed two methods from StateBackend that are only used in tests.
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 6, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@carp84
Copy link
Member Author

carp84 commented Mar 6, 2019

Checked the travis build and confirmed the failure is irrelative to change here. Verified in local travis build and it passed w/o failure.

Copy link
Contributor

@StefanRRichter StefanRRichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and the build failure seems unrelated 👍 Nice job! Will merge.

@StefanRRichter StefanRRichter merged commit f10a7d8 into apache:master Mar 6, 2019
@carp84
Copy link
Member Author

carp84 commented Mar 6, 2019

Thanks Stefan!

asfgit pushed a commit that referenced this pull request Mar 6, 2019
…ckend methods in StateBackend

This closes #7909.

(cherry picked from commit f10a7d8)
HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants