Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11853] [rest] Minimal implementation of POST for /jars/:jarid/plan #7934

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

stephenc
Copy link
Contributor

@stephenc stephenc commented Mar 7, 2019

What is the purpose of the change

Some HTTP Client libraries enforce that GET requests cannot have a request body which means that the request body form of the existing GET /jars/:jarid/plan cannot be used with those clients.
This change replicates the end-point for POST requests also so that the functionality can be accessed irrespective of the chosen HTTP client library.

Brief change log

  • Add the new endpoint.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? The automatic REST API documentation generator documents the additional API endpoint

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 7, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@zentol zentol self-assigned this Mar 7, 2019
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the REST API documentation by running mvn package -Dgenerate-rest-docs -pl flink-runtime-web,flink-docs -am -nsu -DskipTests

Beyond that this looks good.

@zentol
Copy link
Contributor

zentol commented Mar 14, 2019

@flinkbot approve-until quality

@zentol zentol merged commit 1e15c4f into apache:master Mar 21, 2019
@stephenc stephenc deleted the flink-11853 branch March 21, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants