-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-12073][table-planner-blink] Support appropriate precision and scale processing of Decimal #8088
Conversation
…scale processing of Decimal
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
* <p>It differs from {@link BasicTypeInfo#BIG_DEC_TYPE_INFO} in that: | ||
* This type includes `precision` and `scale`, similar to SQL DECIMAL. | ||
*/ | ||
public class BigDecimalTypeInfo extends BasicTypeInfo<BigDecimal> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not calling it DecimalTypeInfo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a TypeInfo
for BigDecimal
, so BigDecimalTypeInfo
is more appropriate.
...k-table-runtime-blink/src/main/java/org/apache/flink/table/typeutils/BigDecimalTypeInfo.java
Show resolved
Hide resolved
LGTM |
…scale processing of Decimal (apache#8088)
…scale processing of Decimal (apache#8088)
What is the purpose of the change
1.Make Decimal's output more precise than random.
2.Let Decimal process closer to mainstream databases such as Hive/SqlServer.
Verifying this change
ut
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation