[FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for simple group aggregate on batch #8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
godfreyhe
changed the title
KurtYoung
reviewed
Apr 2, 2019
|
|
||
| protected def isAggBufferFixedLength(aggBufferTypes: Array[Array[InternalType]]): Boolean = { | ||
| val aggBuffAttributesTypes = aggBufferTypes.flatten | ||
| val isAggBufferFixedLength = aggBuffAttributesTypes.forall(BinaryRow.isMutable) |
There was a problem hiding this comment.
add a TODO to check Decimal can be applied to hash agg, like sum(decimal)
There was a problem hiding this comment.
I have added test case to verify Decimal type in AggregateTestBase#testSum
| * @param agg aggregate | ||
| * @return returns AUXILIARY_GROUP aggCalls' args and other aggCalls | ||
| */ | ||
| def checkAndSplitAggCalls(agg: Aggregate): (Array[Int], Seq[AggregateCall]) = { |
There was a problem hiding this comment.
put this into AggregateUtil?
…zed logical plan for batch simple group aggregate
|
LGTM, +1 |
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Apr 22, 2019
…zed logical plan for simple group aggregate on batch (apache#8092) * [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for batch simple group aggregate * fix checkstyle error * remove Ignore from SingleRowJoinTest, and update based on comments * fix checkstyle error
sunhaibotb
pushed a commit
to sunhaibotb/flink
that referenced
this pull request
May 8, 2019
…zed logical plan for simple group aggregate on batch (apache#8092) * [FLINK-12076] [table-planner-blink] Add support for generating optimized logical plan for batch simple group aggregate * fix checkstyle error * remove Ignore from SingleRowJoinTest, and update based on comments * fix checkstyle error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add support for generating optimized logical plan for simple group aggregate on batch
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation