Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12137][Documentation] Add more proper explanation on flink streaming connectors #8128

Closed
wants to merge 1 commit into from

Conversation

yjk891
Copy link
Contributor

@yjk891 yjk891 commented Apr 9, 2019

What is the purpose of the change

I write on more proper explanation on AWS flink streaming connectors

Brief change log

**

  • Change into SuperClass Config options which prevent IntelliJ from showing warning message

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 9, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@yjk891 yjk891 changed the title [FLINK-12137][component=None] Add more proper explanation on flink streaming connectors [FLINK-12137][component=Documentation] Add more proper explanation on flink streaming connectors Apr 9, 2019
@dawidwys dawidwys changed the title [FLINK-12137][component=Documentation] Add more proper explanation on flink streaming connectors [FLINK-12137][Documentation] Add more proper explanation on flink streaming connectors Apr 10, 2019
@fhueske
Copy link
Contributor

fhueske commented Apr 15, 2019

Hi @yjk891, thanks for your PR!
The changes look good.

@flinkbot approve description consensus architecture quality

I'll merge this PR.
Thanks, Fabian

fhueske pushed a commit to fhueske/flink that referenced this pull request Apr 15, 2019
@yjk891
Copy link
Contributor Author

yjk891 commented Apr 16, 2019

Thanks for acceptance my PR and the review

@asfgit asfgit closed this in 1698a14 Apr 16, 2019
asfgit pushed a commit that referenced this pull request Apr 16, 2019
tianchen92 pushed a commit to tianchen92/flink that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants