Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog #8337

Closed
wants to merge 4 commits into from
Closed

[FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog #8337

wants to merge 4 commits into from

Conversation

bowenli86
Copy link
Member

What is the purpose of the change

This PR creates HiveCatalog in flink-connector-hive module and implements database related APIs for HiveCatalog.

Brief change log

  • Created HiveCatalog and HiveCatalogDatabase
  • Abstracted common part between HiveCatalog and GenericHiveMetastoreCatalog to HiveCatalogBase

Verifying this change

This change added tests and can be verified as follows:

  • Added tests HiveCatalogTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

Documentation will be added later

@flinkbot
Copy link
Collaborator

flinkbot commented May 3, 2019 •
edited

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❗ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

xuefuz
xuefuz reviewed May 4, 2019
View reviewed changes
Copy link
Contributor

@xuefuz xuefuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. I left some comments for consideration. Thanks.

...nk-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogDatabase.java Outdated
// HDFS path of the database
private String location;
// Comment of the database
private String comment = "This is a generic catalog database.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a "generic" catalog, right?

.../flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogUtil.java
public static Database createHiveDatabase(String dbName, CatalogDatabase db) {
HiveCatalogDatabase hiveCatalogDatabase = (HiveCatalogDatabase) db;

return new Database(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is there any use for "comment"?

Copy link
Member Author

@bowenli86 bowenli86 May 4, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused between 'description' and 'comment'. I've created #8340 to complete the javadoc for description. Will address "comment"

...nk-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogDatabase.java
// Comment of the database
private String comment = "This is a generic catalog database.";

public HiveCatalogDatabase(Map<String, String> properties) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other meta classes, properties are optional, where here it's required. Could we make it consistent? If all three variables are optional, we should have a default constructor.

...tors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java Outdated
throws DatabaseNotExistException, CatalogException {
Database hiveDb;

try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should extract this part to the base class, as the logic is the same for generic and hive.

...tors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java Outdated
public void createDatabase(String name, CatalogDatabase database, boolean ignoreIfExists)
throws DatabaseAlreadyExistException, CatalogException {
try {
client.createDatabase(HiveCatalogUtil.createHiveDatabase(name, database));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logics related to hive metastore client can be shared. For example, createDatabase() only needs a hive database object, which might be created differently in the two catalogs. However, once such a object is created, the remaining logic is the same and can be shared.

...tors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java Outdated
public void alterDatabase(String name, CatalogDatabase newDatabase, boolean ignoreIfNotExists) throws DatabaseNotExistException, CatalogException {
try {
if (databaseExists(name)) {
client.alterDatabase(name, HiveCatalogUtil.createHiveDatabase(name, newDatabase));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@bowenli86
Copy link
Member Author

@flinkbot attention @KurtYoung

KurtYoung
KurtYoung approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@KurtYoung KurtYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 to merge

@bowenli86
Copy link
Member Author

Merged

@bowenli86 bowenli86 closed this May 6, 2019
@bowenli86 bowenli86 deleted the hivedb branch May 6, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuefuz xuefuz xuefuz left review comments

@KurtYoung KurtYoung KurtYoung approved these changes

Assignees
No one assigned
Labels
component=TableSQL/API review=description?
Projects
None yet
Milestone
No milestone
5 participants
@bowenli86 @flinkbot @KurtYoung @xuefuz @rmetzger