Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12412] [API / Type Serialization System] Allow ListTypeInfo us… #8351

Closed
wants to merge 1 commit into from

Conversation

Leeviiii
Copy link
Contributor

@Leeviiii Leeviiii commented May 6, 2019

…ed for java.util.List and MapTypeInfo used for java.util.Map

What is the purpose of the change

Allow ListTypeInfo used for java.util.List and MapTypeInfo used for java.util.Map

Brief change log

  • *Allow ListTypeInfo used for java.util.List *
  • Allow MapTypeInfo used for java.util.Map
  • change the test case:PojoTypeExtractionTest.testPojoWC
  • change the test case:TypeExtractorTest.testGenericTypeWithSubclassInput

Verifying this change

This change is already covered by existing tests, such as MapTypeInfoTest,ListTypeInfoTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: yes
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? not documented)

…ed for java.util.List and MapTypeInfo used for java.util.Map
@flinkbot
Copy link
Collaborator

flinkbot commented May 6, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leeviiii please see my comments in the JIRA issue

@Leeviiii
Copy link
Contributor Author

Leeviiii commented May 6, 2019

@Leeviiii please see my comments in the JIRA issue

sorry, I just saw the commends , thanks. I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants