Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12519] [table-planner-blink] Introduce planner rules about semi/anti join #8450

Merged
merged 2 commits into from May 18, 2019

Conversation

godfreyhe
Copy link
Contributor

What is the purpose of the change

Introduce planner rules about semi/anti join

Brief change log

  • added FlinkSemiAntiJoinFilterTransposeRule that pushes semi/anti join down in a tree past a filter
  • added FlinkSemiAntiJoinJoinTransposeRule that pushes semi/anti join down in a tree past a non semi/anti join
  • added FlinkSemiAntiJoinProjectTransposeRule that push semi/anti join down in a tree past a project
  • added ProjectSemiAntiJoinTransposeRule that pushes a project down in a tree past a semi/anti join

Verifying this change

This change added tests and can be verified as follows:

  • Added FlinkSemiAntiJoinFilterTransposeRuleTest that validates FlinkSemiAntiJoinFilterTransposeRule
  • Added FlinkSemiAntiJoinJoinTransposeRuleTest that validates FlinkSemiAntiJoinJoinTransposeRule
  • Added FlinkSemiAntiJoinProjectTransposeRuleTest that validates FlinkSemiAntiJoinProjectTransposeRule
  • Added ProjectSemiAntiJoinTransposeRuleTest that validates ProjectSemiAntiJoinTransposeRule

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@KurtYoung KurtYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@KurtYoung KurtYoung merged commit 4fa3871 into apache:master May 18, 2019
@godfreyhe godfreyhe deleted the FLINK-12519 branch June 1, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants