[FLINK-12432][runtime] Add SchedulerNG stub implementation #8452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
GJL
commented
May 15, 2019
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/SchedulerNGFactoryFactory.java
Show resolved
Hide resolved
tillrohrmann
approved these changes
May 16, 2019
There was a problem hiding this comment.
Thanks for the stub implementation @GJL. LGTM. I had some minor comments which we should address before merging.
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java
Show resolved
Hide resolved
| final RestartStrategyFactory restartStrategyFactory) { | ||
|
|
||
| final String schedulerName = configuration.getString(JobManagerOptions.SCHEDULER); | ||
| switch (schedulerName) { |
There was a problem hiding this comment.
This works for the moment. If we want to make the scheduler truly pluggable, then we should allow to specify the class name of the SchedulerNGFactory.
There was a problem hiding this comment.
Since there is no service loader currently, I think it's ok to leave it as is for now.
...runtime/src/test/java/org/apache/flink/runtime/dispatcher/SchedulerNGFactoryFactoryTest.java
Outdated
Show resolved
Hide resolved
...java/org/apache/flink/runtime/executiongraph/restart/ThrowingRestartStrategyFactoryTest.java
Outdated
Show resolved
Hide resolved
zhuzhurk
reviewed
May 17, 2019
...runtime/src/test/java/org/apache/flink/runtime/dispatcher/SchedulerNGFactoryFactoryTest.java
Outdated
Show resolved
Hide resolved
….reconnect-interval
Move SchedulerNG, SchedulerNGFactory, and its implementations to package org.apache.flink.runtime.scheduler.
Add new SchedulerNG stub implementation, which will represents the future default scheduler. Add feature toggle to switch between existing scheduler and stub implementation. Add ThrowingRestartStrategy to validate that in new scheduling code paths, the legacy restart strategies are not used.
|
Merging as soon as build is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds a stub for the new scheduler.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation