Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-12524] [table-planner-blink] Introduce planner rules about rank #8460

Merged
merged 2 commits into from
May 22, 2019

Conversation

godfreyhe
Copy link
Contributor

What is the purpose of the change

Introduce planner rules about rank

Brief change log

  • added CalcRankTransposeRule that transposes FlinkLogicalCalc past FlinkLogicalRank
    to reduce rank input fields
  • added RankNumberColumnRemoveRule that emoves the output column of rank number iff there is a equality condition for the rank column

Verifying this change

This change added tests and can be verified as follows:

  • Added CalcRankTransposeRuleTest that validates CalcRankTransposeRule
  • Added RankNumberColumnRemoveRuleTest that validates RankNumberColumnRemoveRule

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

}

@Test
def testCannotRemoveRankNumberColumn3(): Unit = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this query actually removed row number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original Rank does not output row number, so RankNumberColumnRemoveRule will not be matched(it requires isRowNumber && constantRowNumber && rank.outputRankNumber is true)

* Planner rule that transposes [[FlinkLogicalCalc]] past [[FlinkLogicalRank]]
* to reduce rank input fields.
*/
class CalcRankTransposeRule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many benefits we can gain from this rule? Is it necessary for some kinds of optimizations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very useful for stream job to reduce Rank state.

@KurtYoung KurtYoung merged commit e6f968c into apache:master May 22, 2019
@godfreyhe godfreyhe deleted the FLINK-12524 branch June 1, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants