-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-12524] [table-planner-blink] Introduce planner rules about rank #8460
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
8c34629
to
fb94db3
Compare
} | ||
|
||
@Test | ||
def testCannotRemoveRankNumberColumn3(): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this query actually removed row number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the original Rank does not output row number, so RankNumberColumnRemoveRule will not be matched(it requires isRowNumber && constantRowNumber && rank.outputRankNumber
is true)
* Planner rule that transposes [[FlinkLogicalCalc]] past [[FlinkLogicalRank]] | ||
* to reduce rank input fields. | ||
*/ | ||
class CalcRankTransposeRule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How many benefits we can gain from this rule? Is it necessary for some kinds of optimizations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very useful for stream job to reduce Rank state.
What is the purpose of the change
Introduce planner rules about rank
Brief change log
to reduce rank input fields
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation